danielleloh / pe

0 stars 0 forks source link

name parameter of person does not allow the inclusion of all types of legal names dues to overly-strict requirements. #4

Open danielleloh opened 4 months ago

danielleloh commented 4 months ago

steps to reproduce

  1. add person with the following : add n/Peppa d/o Daddy Pig a/sesame street p/91234567 e/cookie.monster@example.com (d/o represents daughter-of)

  2. add person with the following: add n/Tan Xiao Ming, Tom a/sesame street p/91234567 e/cookie.monster@example.com

  3. add person with the following: n/Tan Xiao-Ming a/sesame street p/91234567 e/cookie.monster@example.com

expected

the application allows for the addition of the names above as they are common legal name formats found in singapore (i.e. names with commas, d/o, s/o, and dashes etc.)

moreover, reason stated in user guide i.e. ambiguity due to the number present in the name is not sufficient as the names above don't contain any numbers.

actual

the application does not allow the addition of the persons above and outputs the error: Names should only contain alphanumeric characters and spaces, and it should not be blank

screenshots

Screenshot 2024-04-19 at 4.35.01 PM.png

Screenshot 2024-04-19 at 4.37.11 PM.png

Screenshot 2024-04-19 at 4.37.29 PM.png

Screenshot 2024-04-19 at 4.37.50 PM.png

other comments

may want to consider allowing certain common symbols in legal names found in singapore.

nus-pe-script commented 4 months ago

Team's Response

Thank you for raising this issue. After deliberation, we do identify that this is a feature flaw, but we feel that the severity level should be Low instead of Medium. Since we have stated in the UG that names should not include non-alphanumeric characters, users are given a heads-up before they create the contacts to not include dashes, commas etc. There are also work arounds that users can use such as directly indicating daughter of instead of d/o.

Furthermore, considering the target user we have in mind, student leaders in charge of events, more often than not there is no need to save the full legal name of their members, since saving the contacts of members are more for look-up purposes.

As such, we feel that the severity of this issue is Low as it is unlikely to hinder/cause much inconvenience for our target users.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]