search

danielleloh / pe

0 stars 0 forks source link

wrong error displayed when using the export command. #5

Open danielleloh opened 4 months ago

danielleloh commented 4 months ago

steps to reproduce

  1. input export

expected

exports the persons stored in the application.

actual

displays the error: Something went wrong! Make sure export.csv is not open!

however, I do not have any file named export.csv opened at the moment in my device.

screenshots

Screenshot 2024-04-19 at 4.52.30 PM.png

nus-se-bot commented 4 months ago

Team's Response

It is likely that this error is due to the lack of an export file in the directory. It is hard to tell since there is no context given, but during our testing this was the case every time. There is a section to address this in the UG, which specifies creating an export file when using the command. There is also a description of todos and a warning to emphasise this:

image.png

Since it is expected that users would take note of this warning, I believe the error message is not incorrect, since the app is being used in a scenario that it is not meant to be used in. Should the export file have been created, it is likely that this error message would only pop up in appropriate scenarios.

However, if there are any further issues, or missing context that prove otherwise, do follow up on this!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response.

However, I do think that there may have been some misunderstanding and my error report was misinterpreted by the dev team.

From the dev team's response, I interpret that they are trying to convey that it is intended behaviour for the application to throw this error when I have not created an export folder for the CSV file containing the exported content to be created and placed in.

However, as stated in the title of my report, a "wrong error was displayed" when I used the export command. From this, I meant that the error displayed did not match what went wrong. This was explained in the "actual" section of my report. The error message I got was "Something went wrong! Make sure export.csv is not open!", which conveys to me that I am experiencing this error due to the fact that I currently have a file named export.csv opened in my device, which is causing the application to not be able to export content to it. However, as stated in my report (again), at that time, the context was that I did not have a file named export.csv opened in my device.

As stated by the dev team, the error is due to "the lack of an export file in the directory". Therefore, I think that the correct error message that should have been displayed should be along the lines of: "Something went wrong! Please ensure that there is an export folder in the directory!" or "Something went wrong! Missing export folder in the directory!" to match what went wrong. This will correctly convey to users that they need to create an export folder in the directory first before attempting to export anything.

Lastly, although the dev team misunderstood my error report, I do not think that this is a case of my error report being unclear. I have consulted multiple people about my error report and they have all understood what I was trying to convey.

Hope this clarification is helpful!