daniellockyer / apkdiff

Diff between two APK files.

121 stars 24 forks source link

Update apkdiff.py #7

Closed soulee-dev closed 3 years ago

soulee-dev commented 3 years ago

Problem

As mentioned in Issue https://github.com/daniellockyer/apkdiff/issues/4#issuecomment-688746300

Some of OS has problem with line https://github.com/daniellockyer/apkdiff/blob/2468350733765eb2a1c7586d4cdc277fb13ab6ec/apkdiff.py#L81

Suggest

 call(["apktool", "d", "--no-debug-info", "-o", dir, file], stdout=open(os.devnull, 'w'), stderr=STDOUT)

Shell should be true for OS compatibility. If the shell is true, command will be executed through the shell according to Python Docs

Sparrrgh commented 3 years ago

This change broke the tool both in Windows and Ubuntu. Without shell=True it works fine