search

danielm / uploader

A lightweight and very configurable jQuery plugin for file uploading using ajax(a sync); includes support for queues, progress tracking and drag and drop.
https://danielmg.org/demo/java-script/uploader
MIT License
1.17k stars 385 forks source link

Missing semicolon in the minified file #58

Closed Thorium closed 6 years ago

Thorium commented 7 years ago

The minified file, dmuploader.min.js is missing the semicolon from the end of the line.

Then if you have this uploader anywhere else in your javascript file than last library (set by a Javascript-minifier / library-concatenator) the whole thing will fail, as a browser thinks this library is a function taking the next library as an argument.

Luckily the fix is very easy.

Thorium commented 6 years ago

Ok, I think this is actually a problem of the concatenator more than this library.