search

danielma / unsplash-react

React Unsplash Components
22 stars 16 forks source link

Scrollbar breaks three-column layout #7

Open calummonro opened 5 years ago

calummonro commented 5 years ago

Hey danielma,

I can create a PR for this if you want. The scrollbar breaks the column layout:

(Running locally:)

Screenshot 2019-07-24 at 16 01 15

danielma commented 5 years ago

I'd love to see a PR for this! I can duplicate it on my machine, but it's not obvious how to fix it

calummonro commented 5 years ago

Cool, I'll have a look today. I'm not entirely sure either. We can account for the scrollbar width in the photo width calculations, but that will not guarantee consistent results between browsers (or for apps with custom styled scrollbars).

So I'd probably look into CSS Flex or Grid