search

danielmahon / gatsby-remark-relative-images

Convert markdown image src(s) to be relative for gatsby-remark-images.
https://www.npmjs.com/package/gatsby-remark-relative-images
BSD Zero Clause License
79 stars 29 forks source link

Not updating raw html nodes when using gatsby-plugin-mdx #44

Open emanueleperuffo opened 4 years ago

emanueleperuffo commented 4 years ago

I noticed that the following does not work for mdx files in Gatsby

  // Process all HTML images in markdown body
  selectAll('html', markdownAST).forEach((_node: any) => {

Does it make sense to update it to the below?

  // Process all HTML images in markdown body
  selectAll('html, jsx', markdownAST).forEach((_node: any) => {
danielmahon commented 4 years ago

let me look into this, should be trivial but I noticed the MDX plugin works slightly different than remark in regards to its lifecycle hooks, have you had any issues with frontmatter conversion using the mdx plugin?

emanueleperuffo commented 4 years ago

No I haven't. Why are you asking?

On Thu, 10 Sep 2020, 7:55 pm Daniel Mahon, notifications@github.com wrote:

let me look into this, should be trivial but I noticed the MDX plugin works slightly different than remark in regards to its lifecycle hooks, have you had any issues with frontmatter conversion using the mdx plugin?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/danielmahon/gatsby-remark-relative-images/issues/44#issuecomment-690581686, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGZOZPBEYTFTIVTMP45LFDSFEHI3ANCNFSM4REPDB3Q .