Bundle plugin "WTF"

[danielmarschall]

Commit https://github.com/danielmarschall/oidplus/commit/8a3efecdc17a8fdf5d8ea412d3e939f4bf0f7d0c was accidentally added to production without proper verification. It introduces a new 3rd party plugin "WTF".

I will now perform a very quick certification of the plugin in order to see if it fulfills the requirements.

[danielmarschall]

@wehowski

Unfortunately, I have to reject the code from production for now, because there are severe errors which cause OIDplus to get bricked.

Here is the report which lists the errors I have found: https://1drv.ms/w/s!Aq8PcXiGvLchipFaq3slFiDddC11ig?e=0nXRFZ

I will now remove your commit from the core (force-push from current SVN build)

Next steps:

• Please upload the WTF plugin to a GitHub repository and give me the link to that repository. Please mention this GitHub Repository URL in your Manifest.json (the GitHub repository will be the upstream channel for your plugin)
• Then, please try to fix the issues I have mentioned
• When done, please notify me and I will re-check the plugin and continue certification
• If no errors are left, I will bundle it into the core. Don't worry about code-format. At the end I will auto-format your code.

Still, thank you very much for your contribution to OIDplus, and I am looking forward to the updated plugin!

[wehowski]

Hallo @danielmarschall Sorry please excuse my commit fail. Maybe I must create a diffrent branch first?!?

The repo link is https://github.com/frdl/frdl-oidplus-wtf-plugin but I do not know what is the attribute for the manifest.json? Like "homepage" or "repository"? I mentioned it in the description so far.

oidplus-functions.php was renamed to oidplus-functions.inc.php and the INSIDE_OIDPLUS check was added

"wtf-plugin.php should actually be called wtf-plugin.inc.php" : This was discussed before and the decision was wtf-plugin.php so the INSIDE_OIDPLUS check was added!??

The missing functions parameter in WPHooksFunctions.class.php where added

...

I will fix the other issues and notify you, or ask if I have questions...

Viele Grüße Melanie

[danielmarschall]

Danke. Ja, "description" ist der richtige Ort für einen Link zum Upstream Repro.

Ich müsste dich bei OIDplus als Collaborator entfernen, denn die haben Schreibrechte. Ich denke dann würdest du automatisch pullrequests machen, anstelle direkt zu committen. Ich hasse GIT, das ist sowas von verkompliziert...

Neue Branches sind glaube ich auch nicht gut, denn das stört den svn-to-git Prozess möglicherweise auch.

Hier ist übrigens der aktuelle Plan wie der Arbeitsflow läuft: https://raw.githubusercontent.com/danielmarschall/oidplus/d14325ccfa46c76282bc92681d556db1991eb951/plugins/viathinksoft/adminPages/900_software_update/private/oidplus_release_flow.png

[wehowski]

@danielmarschall Neue Version: https://github.com/frdl/frdl-oidplus-wtf-plugin/releases/tag/v0.1.2 Es kommt aber noch vl. was dazu in dieser Woche, ggf. aber in anderen Plugins.

v0.1.2

• removed objectCMSpage to uri- io4- or another plugin
• permalinks by rdap
• oidplus_* functions
  • cache
  • rdap
  • ...
• fixed function typed arguments
• renamed files and added constant checks
• call_user_func* to avoid io4 plugin->NON_EXISTING_METHOD in phpstan
• throws an OIDplus Exception for none mysql systems in quota function to fix this later

...

Viele Grüße Melanie

[wehowski]

https://github.com/frdl/frdl-oidplus-wtf-plugin/releases/tag/v0.1.3

• changed class namespaces for OIDplus-Plugin-like namespaces
• implements Frdlweb\OIDplus\Plugins\PublicPages\RDAP\INTF_OID_1_3_6_1_4_1_37553_8_1_8_8_53354196964_1276945 for filter hooks
• added to filter hooks for oidplus_rdapExtensions:
  • frdlweb_ini_dot
  • redirect_with_content
• additional frdl* and oidplus* functions

[danielmarschall]

@wehowski I changed plans and did a very quick re-certification:

https://1drv.ms/w/s!Aq8PcXiGvLchipFaq3slFiDddC11ig?e=0nXRFZ

Current status:

• PHP Stan errors: 77 errors changed down to 34 errors. Good!
• PHP Storm Error "Union types are only allowed since PHP 8.0" raised from 1 error to approximately 28 errors! VERY BAD! Note that the requirement to run on PHP 7.4 is a strict requirement for OIDplus. Union types cause a syntax error in PHP 7.4. Also, the type "mixed" does not exist in PHP 7.4 and will be confused with a class name

You have solved some PHP-Storm problems but also reintroduced a few new problems. I have updated the errror list for PHP-Storm and PHP-Stan in the document.

I hope this helps!

[wehowski]

Ich arbeite dran, am Plugin und werde die Probleme beheben.

Habe noch einen längeren Text mit Ideen und Anmerkungen notiert. "Plugins dürfen keine Klassen aus dem Vendorverzeichnis benutzen." Das macht es EXTREM aufwendig für OIDplus zu entwickeln!!! Das wtf Plugin soll da einiges vereinfachen, so wie das IO4 Plugin, aber halt OIDplus konform ohne externe Abhängigkeiten. Habe dazu ein Blatt mit Notizen angelegt, auch mit weiteren Roadmaps und ToDos für das RDAP Plugin, es kommen auch noch neue Versionen des wft Plugin. Ich melde mich... mit neuen Infos bzw. wenn Du eine erneute Prüfung vornehmen kannst...

[danielmarschall]

Habe noch einen längeren Text mit Ideen und Anmerkungen notiert. "Plugins dürfen keine Klassen aus dem Vendorverzeichnis benutzen." Das macht es EXTREM aufwendig für OIDplus zu entwickeln!!!

Regarding 3rd party libs and composer there are the following rules for plugin vendors:

(1) You are free to use an own composer.json and vendor directory for your plugin. This is done here:

• https://github.com/danielmarschall/oidplus/tree/master/plugins/viathinksoft/publicPages/100_whois/whois/xml/vendor

• https://github.com/danielmarschall/oidplus/tree/master/plugins/viathinksoft/publicPages/100_whois/whois/json/vendor

So your plugin has its own vendor directory and autoloader. But you just must not use the vendor directory of OIDplus itself. This is property of OIDplus.

(2) Your plugin at GitHub does not need to have a populated vendor directory. It is enough to have a composer.json file. However, when I bundle your plugin into the OIDplus repository, then I will call "composer update" in order to deliver a fully populated vendor directory via the three distribution channels (GIT/SVN/TAR.GZ) allowing easy installation without composer.

[wehowski]

Ok, this will help a lot! 👍