Updates/Changes Available to You

[srseibs]

Hi Daniel - Very nice course, which I really enjoyed. As I code-along with courses, I like to update content to the latest versions and refactor into the latest "best practices". I do this to learn more and apply the knowledge I accumulated.

I just completed your course and my result is here in GitHub. You are free to peruse or steal anything that strikes your fancy. Please don't take this as a criticism of your work - just another take on it in the hope you might find some use.

https://github.com/srseibs/PhotoNotes

Changes I made:

• Latest versions of all dependencies that I found possible.
• I used Material 3 theming since I am trying to learn that.
• I used the standard Extended Icon set instead of custom-built icons
• Passing MutableState directly into sub-Composables is not something I have ever seen in tutorials or code labs; I changed this to a more mainstream val pass parameter plus the use of callback lambda {} for requesting changes. This is much more testable, I think.
• Use "by remember{}" instead of "= remember{}" -- no need to use .value anymore
• Added Hilt injection of ViewModel and the ApplicationContext for the Uri permission helper.
• Use the Theme once - in MainActivity - rather than redundantly using it in all Screens. Screens don't need to know about the particular Theme.
• Stop passing NavController to the Screens... rather have onAction {} lambdas as Screen parameters and handle 100% of the navigation details in the NavHost declaration in MainActivity. Screens don't need to know the details of navigation. Improves reusability and testability.
• Played with Theme fonts and colors. Still sort of ugly, but an example of how to use a custom Font and theming in Material 3.

[danielmbutler]

Thanks for sending this over much appreciated, I like the changes you made, I am trying to learn theming myself so its good to see your approach, I did think about including in Hilt but deliberately omitted it from the course as I want to focus more on Compose rather than DI. I do like the changes you made for the Theme, Navcontroller and the use of "by remember" so i will look into adding those.

Glad you enjoyed the course.

Happy coding !

Daniel