search

danielmoncada / date-time-picker-moment-adapter

Moment.js adapter for https://github.com/danielmoncada/date-time-picker
MIT License
5 stars 9 forks source link

Angular 17 moment adapter #15

Closed pavlikxor closed 10 months ago

sabareeshnarayanaswamy commented 11 months ago

Could you please let know when this PR will be merged and officially released ?

danielmoncada commented 10 months ago

Shouldn't we update the tsconfig files here like you did in the dayjs adapter?

@neodescis

im not even sure why some of the changes were made on the dayjs adapter (regarding the config). this pr has bare minimum updates (which I prefer). I've fixed a few things with it, and was able to package it.

going to release it now, as is. is there anything in particular you want changed to it? i can do a patch release if so.

sidenote: appreciate you helping out, leaving comments, and doing code reviews. admittedly, I haven't had enough time for this, especially since I've moved on to Vue (for my day job).

danielmoncada commented 10 months ago

Could you please let know when this PR will be merged and officially released ?

@sabareeshnarayanaswamy this has been released, v4.0.0

neodescis commented 10 months ago

Shouldn't we update the tsconfig files here like you did in the dayjs adapter?

@neodescis

im not even sure why some of the changes were made on the dayjs adapter (regarding the config). this pr has bare minimum updates (which I prefer). I've fixed a few things with it, and was able to package it.

going to release it now, as is. is there anything in particular you want changed to it? i can do a patch release if so.

sidenote: appreciate you helping out, leaving comments, and doing code reviews. admittedly, I haven't had enough time for this, especially since I've moved on to Vue (for my day job).

Happy to help out. We've actually been considering creating a (private) fork of this (for my day job), but meanwhile I have a vested interest in seeing it updated!

As for the tsconfig changes, the PR for dayjs has changes that restructure the tsconfig files like a new Angular 17 project. The structure of the tsconfig files in this repo is no longer current. It's not harming anything per se though.

danielmoncada commented 10 months ago

Shouldn't we update the tsconfig files here like you did in the dayjs adapter?

@neodescis im not even sure why some of the changes were made on the dayjs adapter (regarding the config). this pr has bare minimum updates (which I prefer). I've fixed a few things with it, and was able to package it. going to release it now, as is. is there anything in particular you want changed to it? i can do a patch release if so. sidenote: appreciate you helping out, leaving comments, and doing code reviews. admittedly, I haven't had enough time for this, especially since I've moved on to Vue (for my day job).

Happy to help out. We've actually been considering creating a (private) fork of this (for my day job), but meanwhile I have a vested interest in seeing it updated!

As for the tsconfig changes, the PR for dayjs has changes that restructure the tsconfig files like a new Angular 17 project. The structure of the tsconfig files in this repo is no longer current. It's not harming anything per se though.

Ah, that makes sense.

I mean, feel free to make a PR if ya want to adhere to the new ng 17 config format. I think the moment adapter didnt build for me, I'll review and test again as I see there are new changes.