search

danielmoncada / date-time-picker

Angular Date Time Picker (Responsive Design)
https://daniel-projects.firebaseapp.com/owlng/date-time-picker
MIT License
140 stars 60 forks source link

ngcc not changing node_modules/@danielmoncada/angular-datetime-picker code #100

Closed stepet80 closed 3 years ago

stepet80 commented 3 years ago

Ngcc doesn't seem to be adapting the package? Is it a known issue or am I doing something wrong. I have a script postinstall: 'ngcc'. Other packages are being tweaked by ngcc...

stepet80 commented 3 years ago

Ok nevermind. i did 'ngcc --target @danielmoncada/angular-datetime-picker' and it told me moment was missing as a dependency. Maybe it should be added as a peer dependency?

danielmoncada commented 3 years ago

@stepet80 yeah, the dependency has been there since I forked the original. This is because the author added the adapters as part of the package itself.

See discussion at: https://github.com/danielmoncada/date-time-picker/issues/20