search

danielmoncada / date-time-picker

Angular Date Time Picker (Responsive Design)
https://daniel-projects.firebaseapp.com/owlng/date-time-picker
MIT License
140 stars 60 forks source link

Invalid input is silently discarded #107

Open komu opened 3 years ago

komu commented 3 years ago

I have an existing time in the picker, then open the picker and input invalid hour:

Screenshot 2021-01-29 at 12 45 54

Nothing is indicated as being invalid and Set button is enabled. When I click Set, the valid parts of my input (minutes) are set to new values, but the invalid hours are not:

Screenshot 2021-01-29 at 12 46 16

Similarly if I would have entered 13:65 as input, the valid part (hours) would have been copied, but the minutes not. Same happens if either hours or minutes are left completely blank.

I would expect that Set is disabled when the input in the dialog is not valid.

danielmoncada commented 1 year ago

closing.. stale

komu commented 1 year ago

Then again, the problem still seems to be there.

danielmoncada commented 1 year ago

@komu okay, I'll re-open. feel free to make a PR to fix it 👍