search

danielmoncada / date-time-picker

Angular Date Time Picker (Responsive Design)
https://daniel-projects.firebaseapp.com/owlng/date-time-picker
MIT License
142 stars 61 forks source link

Angular 15 Support #172

Closed mmoreno79 closed 1 year ago

mmoreno79 commented 1 year ago

Currently the latest angular version supported is 14. Can we get angular 15 added?

jtc10005 commented 1 year ago

Looks like PR #171 is to do this.

KeithGillette commented 1 year ago

In attempting to upgrade from Angular 14.2.7 to 15.0.2, I get the following build error:

./applications/browser/src/styles.scss - Error: Module build failed (from ./node_modules/css-loader/dist/cjs.js):
Error: Package path ./assets/style/picker.min.css is not exported from package /path/to/node_modules/@danielmoncada/angular-datetime-picker (see exports field in /path/to/node_modules/@danielmoncada/angular-datetime-picker/package.json)

./applications/browser/src/styles.scss?ngGlobalStyle - Error: Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
HookWebpackError: Module build failed (from ./node_modules/css-loader/dist/cjs.js):
Error: Package path ./assets/style/picker.min.css is not exported from package /path/to/node_modules/@danielmoncada/angular-datetime-picker (see exports field in /path/to/node_modules/@danielmoncada/angular-datetime-picker/package.json)
danielmoncada commented 1 year ago

v15 now published: https://www.npmjs.com/package/@danielmoncada/angular-datetime-picker/v/15.0.0

KeithGillette commented 1 year ago

@danielmoncada — Thanks for your work supporting Angular 15. I still get the Angular CLI errors I previously reported when trying to build a project with Angular 15.0.2 and @danielmoncada/angular-datetime-picker@15.0.0. Here is the relevant entry from src/styles.scss:

@import '@danielmoncada/angular-datetime-picker/assets/style/picker.min.css';
KeithGillette commented 1 year ago

I am still experiencing the CSS import build error with Angular 15.0.4. I have isolated the incompatibility to @angular-devkit/build-angular@^15.0.0, which is used by Nx in our monorepository. I'm assuming this has something to do with the changes to SASS and CSS handling noted in the @angular-devkit/build-angular section of the release notes.