search

danielmoncada / date-time-picker

Angular Date Time Picker (Responsive Design)
https://daniel-projects.firebaseapp.com/owlng/date-time-picker
MIT License
141 stars 61 forks source link

Locales Are Not Working As Before #33

Closed gongAll closed 4 years ago

gongAll commented 4 years ago

I changed from the main repo for this one with a working translatable date time picker. Right now, translations seem to not be working. Please fix this. :)

global.error-handler.ts:13 Error: Missing locale data for the locale "pt-BR".
    at findLocaleData (core.js:23261)
    at getLocaleFirstDayOfWeek (common.js:1186)
    at new OwlMonthViewComponent (danielmoncada-angular-datetime-picker.js:4693)
    at NodeInjectorFactory.OwlMonthViewComponent_Factory [as factory] (danielmoncada-angular-datetime-picker.js:5197)
    at getNodeInjectable (core.js:3900)
    at instantiateAllDirectives (core.js:8267)
    at createDirectivesInstances (core.js:7659)
    at Module.ɵɵelementStart (core.js:14360)
    at OwlCalendarComponent_owl_date_time_month_view_18_Template (danielmoncada-angular-datetime-picker.js:26)
    at executeTemplate (core.js:7632)
...
danielmoncada commented 4 years ago

@gongAll thanks, I'll flag this to take a look

gongAll commented 4 years ago

after reading this: https://angular.io/guide/i18n I understood that "pt-BR" is now only "pt", its not an error on your side! Closing for that reason. Might make sense to make it explicit that the locale keys are the ones from angular common on the component documentation tho.

Cheers, and thank you for the fork!

danielmoncada commented 4 years ago

@gongAll thanks for the quick update. Yes, I agree, will update the documentation.