search

danielmoncada / date-time-picker

Angular Date Time Picker (Responsive Design)
https://daniel-projects.firebaseapp.com/owlng/date-time-picker
MIT License
141 stars 61 forks source link

Make YEARS_PER_ROW & YEAR_ROWS customizable #82

Closed Lonli-Lokli closed 2 years ago

Lonli-Lokli commented 3 years ago

Currently it's constants

export const YEARS_PER_ROW = 3; export const YEAR_ROWS = 7;

Could you move them to the options?

danielmoncada commented 3 years ago

@Lonli-Lokli thanks, I'll look over and merge the PR sometime today.

danielmoncada commented 3 years ago

@Lonli-Lokli can you create a new pull request? I initially merged it (should have checked before hand), but there were some issues in the UTs.. I had fixed them, but a bunch are still failing so I went head and reverted the merge.

Lonli-Lokli commented 3 years ago

@danielmoncada I know it was in previous year, sorry about that. I've created PR one more time