danielnaber / jwordsplitter

small Java library for splitting German compound words
Other
62 stars 11 forks source link

GermanWordSplitter NPE when accessing disambiguator #13

Closed simasch closed 7 years ago

simasch commented 7 years ago

disambiguator is null when using the new constructor.

danielnaber commented 7 years ago

Should be fixed, I actually forgot to call init(), which was probably also the cause for #12.

simasch commented 7 years ago

But init() will call getWordList() and will load the EmbeddedGermanDictonary.

protected Set<String> getWordList() {
    return EmbeddedGermanDictionary.getWords();
}

Is this correct?

danielnaber commented 7 years ago

Using the embedded dictionary for GermanInterfixDisambiguator seems correct - that's not the main dictionary, but rather a (very simple) attempt to remove ambiguities.

simasch commented 7 years ago

Ok. Got you Thanks.