danielnieto / electron-download-manager

Manage downloadItems from Electron's BrowserWindows without user interaction, allowing single file download and bulk downloading
MIT License
120 stars 50 forks source link

Download url with query string #27

Closed cbh6 closed 5 years ago

cbh6 commented 5 years ago

I'm having issues with this. Downloading from url like this 'https://somedownloadsite.com/download/video.mp4?param=123123

Throws this log message

video.mp4?param=123123 does not exist, download it now.

Seems that query string params are being used along with the name to search if the file is already downloaded.

danielnieto commented 5 years ago

what is the expected behavior? to download the file with different params or to not download it?

cbh6 commented 5 years ago

Just to ignore the params when checking if the file is already downloaded.

Now is using the video name with the url query string params to check if the video exists.

danielnieto commented 5 years ago

Resolved with #33, thank you!