danielnieto / electron-download-manager

Manage downloadItems from Electron's BrowserWindows without user interaction, allowing single file download and bulk downloading

MIT License

120 stars 50 forks source link

Download Url with query string doesn't find file name properly #6

Closed syedhabib53 closed 6 years ago

syedhabib53 commented 7 years ago

Line98 we are using response.request.uri.href to find file name instead response.request.uri.pathname.

danielnieto commented 7 years ago

does your pull request fix this issue?

syedhabib53 commented 7 years ago

Yes. And I have fixed one more issue, that the response returns encode uri. Check my latest commits.

danielnieto commented 7 years ago

sorry for taking so long, I've been super busy at my job, I merged some other PR and it conflicts with yours but I haven't checked what the conflict is, I'll do that later today

danielnieto commented 6 years ago

14 this fixes this issue

cbh6 commented 5 years ago

I'm having issues with this. Downloading from url like this 'https://somedownloadsite.com/download/video.mp4?param=123123

Throws this log message

video.mp4?param=123123 does not exist, download it now.