danielonges / pe

0 stars 0 forks source link

Able to add a patient with the same phone and same email #1

Open danielonges opened 3 years ago

danielonges commented 3 years ago

Patients with different names but the same phone number and email are allowed to be added into the application. Rightfully, a patient record should have a unique phone and email in order to be identified uniquely when it comes to scheduling appointments. Here's the commands that I used in succession:

  1. add-patient n/John Doe p/98765432 e/johnd@example.com a/Johnstreet, block 123, #01-01
  2. add-patient n/John Smith p/98765432 e/johnd@example.com a/Johnstreet, block 123, #01-01

And here is the result being shown in the application (both patients can be added in, even though they have the same phone and email):

image.png

nus-pe-bot commented 3 years ago

Team's Response

Different way of expressing the same underlying problem of ways to determine a unique person

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to add patient that has same name as existing records, but different phone, email and address

I was unable to add a patient that had the same name as existing records, but different phone, email and address. Realistically, it is possible to have two patients with the same name and surname, but be two completely different people with different phones, emails, and addresses. These are the commands that I executed:

  1. add-patient n/John Doe p/98765432 e/johnd@example.com a/Johnstreet, block 123, #01-01
  2. add-patient n/John Doe p/999 e/helloworld@example.com a/10 Heng Mui Keng Terrace, block 123, #01-01

This is the error I got from the application:

image.png


[original: nus-cs2103-AY2021S2/pe-interim#803] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Identification of persons cannot be reliably determined by email or phone number either:

  1. Person may register under a company email which can be shared (same can be said about a phone number)
  2. Person may register under a phone number which was previously registered under another person.
  3. The only fail safe way to ensure uniqueness would be to register using an identification number such as NRIC.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]