search

danielpalme / IocPerformance

Performance comparison of .NET IoC containers
https://danielpalme.github.io/IocPerformance
Apache License 2.0
876 stars 157 forks source link

adding asp.net core test #68

Closed ipjohnson closed 7 years ago

ipjohnson commented 7 years ago

PR for issue #66

ipjohnson commented 7 years ago

Rough numbers can be found Here

danielpalme commented 7 years ago

@ipjohnson: Thanks for the PR. You updated Autofac and Castle Windor. The problem is, that "Castle.Windsor.3.4.0" is not working with "Castle.Core.4.0.0"... Currently this container benchmark can no longer be executed.

I did not update Autofac an Castle.Windor for some time now, to keep them both working (both depend on Castle.Core).

But Autofac needs to be updated in order to support asp.net core.

What should we do?

ipjohnson commented 7 years ago

I had seen that but I jut figured I'd done something wrong.

I found this issue but it doesn't seem to suggest any way to work around it. @jonorossi any suggestions?

Maybe it's a matter of removing Windsor from the benchmark for the moment but publish the 3.3.0 results till 4.0.0 is released? Holding back Autofac from being upgraded because Castle.Windsor is incompatible with Castle.Core 4.0.0 seems wrong.

jonorossi commented 7 years ago

The problem is, that "Castle.Windsor.3.4.0" is not working with "Castle.Core.4.0.0"...

They are not compatible, Windsor 3.4.0's dependencies state: Castle.Core (>= 3.3.0 && < 4.0.0).

Windsor does not yet support .NET Core/Standard, while Castle Core (including Castle DynamicProxy) does. There is currently no workaround for using Windsor 3.x.x with Castle Core 4.0.0 as there were some breaking changes. There is work underway on Windsor 4.0, so it is your call how you want to handle this until then, we need to make a minor Windsor release soon so we could see how much work it would be to support Castle Core 4.0.0 until Windsor 4.0 comes.

danielpalme commented 7 years ago

I would suggest, we let the Castle.Windsor tests fail until the new release is available.