Calculate C.R.A.P. Score from Cobertura file?

[rikrak]

Not so much a bug as a feature request/question.

When processing Cobertura files, would it be possible to also calculate the crap score? Corbertura itself doesn't provide a value for this metric, but it looks possible to calculate it from the Cyclomatic Complexity and Coverage values for each method using: CRAP(m) = CC(m)^2 * U(m)^3 + CC(m) Where CC(m) = Cyclomatic Complexity (e.g. 5) U(m) = Uncovered percentage (e.g. 30% = 0.3)

I've played about with the code locally and produced a report from cobertura that does this. Just wondering if this is worth working into a PR?

[rikrak]

For info, here's a snippet:

    // CoberturaParser.cs

        private static void SetMethodMetrics(CodeFile codeFile, IEnumerable<XElement> methodsOfFile)
        {
            foreach (var method in methodsOfFile)
            {
                string fullName = method.Attribute("name").Value + method.Attribute("signature").Value;
                fullName = ExtractMethodName(fullName, method.Parent.Parent.Attribute("name").Value);

               // ... abridged for clarity

                if (cyclomaticComplexity.HasValue && coveragePercent.HasValue)
                {
                    // https://testing.googleblog.com/2011/02/this-code-is-crap.html
                    // CRAP(m) = CC(m)^2 * U(m)^3 + CC(m)
                    // CC(m) <= Cyclomatic Complexity (e.g. 5)
                    // U(m) <= Uncovered percentage (e.g. 30% = 0.3)
                    var uncoveredPercent = (100f - (double)coveragePercent.Value) / 100.0;
                    var complexity = (double)cyclomaticComplexity.Value;
                    var crapScore = (Math.Pow(complexity, 3.0) * Math.Pow(uncoveredPercent, 2)) + complexity;

                    metrics.Insert(0, Metric.CrapScore((decimal)crapScore));
                }

               // ... abridged for clarity
            }
        }

[danielpalme]

@rikrak That sound great! If you like, you can create a PR, but I'm also able to use your snippet to add this metric. Just let me know how you would like to handle it.

[rikrak]

I'll put together a PR :-)

[rikrak]

I've submitted a PR. I'm quite new to contributing to OS projects, so let me know if the PR needs adjusting in any way :-)

[danielpalme]

Thank you!

[danielpalme]

Release 5.2.1 is now available containing the new metric!

[rikrak]

Terrific, I'll check it out tomorrow :-)