Fix sort direction triangles

danielpalme / ReportGenerator

ReportGenerator converts coverage reports generated by coverlet, OpenCover, dotCover, Visual Studio, NCover, Cobertura, JaCoCo, Clover, gcov or lcov into human readable reports in various formats.

https://reportgenerator.io

Apache License 2.0

2.65k stars 283 forks source link

Fix sort direction triangles #677

Closed YuriyDurov closed 5 months ago

YuriyDurov commented 5 months ago

Risk hotspots and coverage info tables' triangle icons show incorrect sorting direction.

The triangles represent a stack of items like a Tower of Hanoi toy.

An upwards-pointing triangle ▲ represents a stack with the narrowest (ie, smallest) item on top and the widest (ie, largest) item on the bottom, hence an ascending list.
A downwards-pointing triangle ▼ represents a stack with the widest (ie, largest) item on top and the narrowest (ie, smallest) item on the bottom, hence a descending list.

YuriyDurov commented 5 months ago

Hello @danielpalme! I have noticed ordering triangles being wrong when using your report generator and decided to fix it right away in your source code. Not exactly sure this is entirely correct as I am not sure how I could test this. I am only using the generator in my azure pipeline and have no experience in building it from source code.

danielpalme commented 5 months ago

Thank you! I will have a look and merge your PR within the next days.