search

danielparks / puppet-rustup

Puppet module to manage Rust with rustup
https://forge.puppet.com/modules/dp/rustup/readme
Other
0 stars 0 forks source link

Switch back to require_relative #35

Closed danielparks closed 1 year ago

danielparks commented 2 years ago

@danielparks Hi! thanks for the awesomme module. Stupid question, could you revert this commit? With require_relative, environment isolation works. Puppet will ensure that the loaded lib comes from the same environment as the type and provider. With just using require, you potentially load the puppet_x lib from another code environment and cause some trouble. An example PR is https://github.com/puppetlabs/puppetlabs-stdlib/pull/1275. We (voxpupuli.org) and Puppet are currently checking for a rubocop rule to even enforce require_relative.

Originally posted by @bastelfreak in https://github.com/danielparks/puppet-rustup/issues/29#issuecomment-1288507197