danielpaulus / go-ios

This is an operating system independent implementation of iOS device features. You can run UI tests, launch or kill apps, install apps etc. with it.
MIT License
964 stars 184 forks source link

Check for non-empty 'Error' string in 'StartSessionResponse' #515

Closed buxomant closed 1 week ago

buxomant commented 1 week ago

Issue: When sending a StartSession request, we just check if there was an error reading the response message. However, we don't check if the response object itself contains an Error field.

Fix: Start checking for the Error field, and if present return an error accordingly.

buxomant commented 1 week ago

For context, the use case here was a device paired with a host, but pairing was broken after the device was factory reset. This was detected by idevicepair validate, but was not detected by go-ios, until this fix.