Fixes the basename .. bug

danielpclark / faster_path

Faster Pathname handling for Ruby written in Rust

MIT License

782 stars 33 forks source link

Fixes the basename .. bug #164

Closed glebm closed 6 years ago

glebm commented 6 years ago

Fixes #162

This incorporates all the Rust tests added by @danielpclark's in #163 and adds a few more. There does not seem to be any noticable performance impact.

glebm commented 6 years ago

Found a few other bugs, will add tests here

coveralls commented 6 years ago

Coverage remained the same at 85.714% when pulling 38d7b7fcb5736061738c4cd82836ea913ae24248 on glebm:fix-basename into 3f40f1868fa347d9ba272aef180aabe37f040046 on danielpclark:master.

glebm commented 6 years ago

@danielpclark I've updated the PR with some more tests and fixes.