danielpclark / faster_path

Faster Pathname handling for Ruby written in Rust
MIT License
781 stars 29 forks source link

Add FasterPath.add_trailing_separator #45

Closed mble closed 8 years ago

mble commented 8 years ago

https://github.com/danielpclark/faster_path/issues/43

danielpclark commented 8 years ago

Looks good. Can you add a few tests that compare the two methods against each other? assert_eq FasterPath.add_trailing_sparator(str), Pathname.allocate.send(:add_trailing_separator, str) and in the stats section of the readme since Pathname's method is an instance method it would be represented with a pound symbol Pathname#add_trailing_separator . That's my fault for labelling it wrong in this open issue.

mble commented 8 years ago

All done @danielpclark