search

danielperna84 / hass-configurator

Configuration UI for Home Assistant
MIT License
313 stars 168 forks source link

Version mismatch in repo and gui #203

Closed Caroga closed 4 years ago

Caroga commented 4 years ago

Hi,

In pursuit of debugging #202 I've checked if the docker image I was using is up-to-date with the latest version of the hass-configurator. I encountered a version mismatch being displayed in the GUI of the configurator, which at first made me open an issue at the downstream of this repo.

I later found that the version inside configurator.py is fixed here:

https://github.com/danielperna84/hass-configurator/blob/1a7775de089e504e5b8302fdb77df741af7da1e2/configurator.py#L114

Which also shows in the gui here:

image

I don't know if this is intentional but I'd thought it was worth mentioning as this is confusing or a bug otherwise.

Hoping this might be of help.

danielperna84 commented 4 years ago

The problem is in the Dockerfile. It's still using the legacy configurator.py. The configurator however has changed to be distributed as a package via pip. The package includes this configurator.py, which correctly has 0.4.0 as the version tag.

So essentially the Dockerfile has t obe updated to not use the old configurator file and copy it into the container, but instead install the package from pip. So your issue in the other repo is valid, as it has to be fixed there.