Hide Ace errors - Githubissues

danielperna84 / hass-configurator

Configuration UI for Home Assistant

MIT License

306 stars 168 forks source link

Hide Ace errors #228

Closed ludeeus closed 2 years ago

ludeeus commented 2 years ago

Changes the workaround to properly define custom tags
Hides Ace editor errors with CSS as these are handled by js-yaml anyway

Closes #226

danielperna84 commented 2 years ago

Please exclude the files at the root of the repo. Those are the legacy files which are not maintained anymore. Also my workaround should be removed if it's not needed anymore to re-enable linting.

Apart from that great work. 👍

danielperna84 commented 2 years ago

And while we're at it: wouldn't we be able to remove our custom yaml-linting? That way we could get rid of the js-yaml source file in this repo and not serve it locally. Which I guess would require not hiding the Ace-error via CSS. But I think it would be nice to actually have the error-indicator in the editor instead of the red mark, which the user has to click to reveal more information. 🤔

Edit:
Ignore what I said. I somehow thought this would impact the linting in Ace, although it doesn't.

ludeeus commented 2 years ago

Messed up

ludeeus commented 2 years ago

It seems like my fork was behind, what you did in https://github.com/danielperna84/hass-configurator/commit/9e369689afcc094a1a1a2cb247e9e93adf772e4c works better than CSS hack.