danielpronych / python-twitter

Automatically exported from code.google.com/p/python-twitter
Apache License 2.0
0 stars 0 forks source link

Add Basic support for searching #114

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Hello, attached you'll find a patch which adds three features:

- Support for other API providers (identi.ca, wordpress, etc)
- Support for the test method
- Basic support for searching

I've also extended the test suite to cover the new methods (and also some old 
methods which were reported as uncovered). Please let me know what you thing 
of it and what (if anything) I should change so that it can be integrated in 
trunk.

Best regards.

Original issue reported on code.google.com by dify....@gmail.com on 22 Dec 2009 at 1:22

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for the patch!  It isn't applying cleanly against the current trunk, 
however.

One idea might be for you to make a clone of the hg repository 
(http://code.google.com/p/python-twitter/source/clones), make the changes 
there, and 
send me a request for a code review.  Once everything looks good to go we can 
pull 
from your clone back into the main repository.

Sound like a good idea?

Original comment by dclinton on 23 Dec 2009 at 8:27

GoogleCodeExporter commented 8 years ago
Hello.

First of all, I would like to apologize for mispelling "think" in my previous 
message.

I don't have a lot of experience with DVCS's in general and hg in particular 
(SVN is
as far as I got in my evolution :-p). If I understand correctly, the process you
describe would require me to set up a public repository with the changes, which 
seems
to be a rather complicated and wasteful process (for example I could use Google 
Code,
but since I'm currently not planning on contributing to the code frequently - 
sorry -
it would just mean one more abandoned project on Google Gode, wouldn't it?)

The patch seem to apply cleanly on my end. This is how I do it:

- I check out a copy of python-twitter in the current directory:

  hg clone https://python-twitter.googlecode.com/hg/ .

- I run patch:

  patch < search_dotest_custom_api.patch

What am I missing here? If you think that setting up a public hg repo is the 
best
option to do it, I will do so, but again - it just seems so wasteful...

Original comment by dify....@gmail.com on 25 Dec 2009 at 5:17

GoogleCodeExporter commented 8 years ago
Ok, I just found out how easy it is to clone a repository. So I've done it and 
added
the previously attached patch to it:

http://code.google.com/r/difyltd-python-twitter-extra/

Hopefully I've done it right, this is my first time :-)

If you are interested: I already have the code for basic geo support (it only 
puts
the data in a dictionary on the Status object, nothing fancy). I'm also working 
on
list support.

Best regards.

Original comment by dify....@gmail.com on 11 Jan 2010 at 7:57

GoogleCodeExporter commented 8 years ago
Changing the summary to alter the focus for the Issue from laconica/Identica 
sites to adding support for Search

Identica support was added as part of Issue 37

Original comment by bear42 on 18 Aug 2010 at 7:04