danielptv / bookmark-bar-switcher

Browser extension which enables the user to switch between multiple bookmark bars.
MIT License
9 stars 3 forks source link

Doesn't work on Opera GX #213

Open Rodolphe-dev opened 10 months ago

Rodolphe-dev commented 10 months ago

Doesn't work on Opera GX

Description

After left click on the logo on the top right, only a white square appear with nothing in it

Reproduction

Click on the extension logo on the top right

Environment

Opera GX

Kamiikaze commented 10 months ago

It's working fine for me on Opera GX. Screenshot

Can you provide a screenshot and maybe check the console?

Right-Click on the Extension > Inspect Pop-up and Right-Click on the Extension > Manage Extension > Under Inspect Views check service worker console

Also check if the folder "Bookmark Bars" is created in "Other Bookmarks"-Folder

Rodolphe-dev commented 10 months ago

2023-12-10 23_07_40-Window

here the screenshot of what i have and no folder created. By the way i'm a bit lost with your instruction about the console

EDIT: my bad my browser wasn't in Dev Mode, so i got only this

2023-12-10 23_16_05-Window

Kamiikaze commented 10 months ago

Can you try creating the folder "Bookmark Bars" manually in the "Other Bookmarks" folder and see if this fix it?

Rodolphe-dev commented 10 months ago

I created the folder and same 2023-12-11 15_50_17-Window

Kamiikaze commented 10 months ago

Okay, weird. Can you try checking the console of the service worker? Go to your Extensions > Find Bookmark Bar Switcher > Click on Details > Click on service worker as on screenshot below.

img

Rodolphe-dev commented 10 months ago

2023-12-11 16_01_15-

Kamiikaze commented 10 months ago

I change Browser to french and see that the first default Bookmark Folder doesn't gets created. But I still see the buttons to create a new folder, which isn't the case on your side.

image

Try creating folders inside the Bookmark Bars Folder.

Rodolphe-dev commented 10 months ago

"I change Browser to french and see that the first default Bookmark Folder doesn't gets created." Even after changed in English (US) it doesn't create the folder : Bookmark Bars

"But I still see the buttons to create a new folder, which isn't the case on your side." Inside the app or the setting bookmark from opera ? Coz i see them in both language 2023-12-11 16_18_58-Window 2023-12-11 16_19_31-Window

"Try creating folders inside the Bookmark Bars Folder." Here ? 2023-12-11 16_20_23-Window

danielptv commented 10 months ago

Even if there are no folders the extension interface should be displayed. Therefore I am a bit perplexed by this bug. @Kamiikaze are you using Opera GX or the normal Opera Browser? I have tested on Opera Browser only before last release.

The failed creation of the Bookmark Bars-folder is also interesting. Does the equivalent of the Other Bookmarks-folder have a different id in other languages?

Rodolphe-dev commented 10 months ago

I tried to disabled all my other extension but it's the same, i did a bit of digging in the error inspect popup

here the screenshot: 2023-12-11 16_49_36-Window 2023-12-11 16_49_36-Window

Kamiikaze commented 10 months ago

"But I still see the buttons to create a new folder, which isn't the case on your side." Inside the app or the setting bookmark from opera ? Coz i see them in both language

For me it looks like this if there is no folder image

"Try creating folders inside the Bookmark Bars Folder." Here ?

I mean inside Other Bookmarks > Bookmark Bars > New Folder

are you using Opera GX or the normal Opera Browser?

I'm using Opera GX

Kamiikaze commented 10 months ago

Does the equivalent of the Other Bookmarks-folder have a different id in other languages?

Checked it, it's the same ID in different languages

Rodolphe-dev commented 10 months ago

"I mean inside Other Bookmarks > Bookmark Bars > New Folder" Yep still no change

danielptv commented 10 months ago

Very strange. Have you tried reinstalling already? I am struggling to reproduce this error right now.

@Kamiikaze For you it works fine on both Opera and Chrome?

For me it looks like this if there is no folder image

Yeah, that's what it should look like.

Kamiikaze commented 10 months ago

For you it works fine on both Opera and Chrome?

Yea, working fine on both.

Rodolphe-dev commented 10 months ago

"Very strange. Have you tried reinstalling already?" Multiple time between change language in Opera GX and folders creation

It work like a charm on chrome for me btw

danielptv commented 10 months ago

Damnit. So it that case it must be relatrd to the Opera-specific parts if the code somehow or it is somehow related to Opera itself or the Chromium version it is using.

@Rodolphe-dev @Kamiikaze please check if both of you are usung the same Opera version

Kamiikaze commented 10 months ago

That's my current version image

Rodolphe-dev commented 10 months ago

I had the same version as Kamiikaze but Opera just updated to this update : 2023-12-11 18_48_34-Window

Kamiikaze commented 10 months ago

Did you tried the extension in chrome? Is it working there? @Rodolphe-dev

Rodolphe-dev commented 10 months ago

yep like i said work on chrome very well

Kamiikaze commented 10 months ago

I will install Opera GX in French on a new pc and install the extensions. Because I can't reproduce the issue, even with a new Opera GX Profile.

Kamiikaze commented 10 months ago

Even on a fresh Opera GX install on my privat Win10 VM, there were no Issues. It created the folders by default and shows them in the list.

image

Can you try creating a new Opera GX Profile with this extension only and see if it works? opera://settings/side-profiles-settings

Rodolphe-dev commented 10 months ago

@Kamiikaze it work now ! But don't know how to fix it on my actual profile ...

Kamiikaze commented 10 months ago

@Kamiikaze it work now ! But don't know how to fix it on my actual profile ...

Sounds good. It seems that removing the extension, doesn't delete the items in the chrome.storage. Maybe there is an issue at this side.

Rodolphe-dev commented 10 months ago

"Paste a screenshot of the result. Should look like this:" 2023-12-14 10_03_46-NVIDIA GeForce Overlay

It doesn't look like you and still not working

Kamiikaze commented 10 months ago

Hmm interesting. It seems it didn't even touched the sync storage.

As I mentioned in Issue #218 I will create a new branch where I add more logging for better debugging. If I'm done, you can try this version and maybe we will see where it fails. Not sure if I can do it today, but definitely this week.

Rodolphe-dev commented 10 months ago

no problem feel free to tell me when it's done

Kamiikaze commented 10 months ago

Added now more logging. There is a visual bug, where new added bookmarks are not visible immediately but after reopening the extensions. So still function.

Rodolphe-dev commented 10 months ago

Tell me if you need something else 2023-12-17 12_01_01-Window

Rodolphe-dev commented 9 months ago

any news about the issue ?