search

danielr18 / connected-next-router

A Redux binding for Next.js Router compatible with Next.js.
MIT License
109 stars 30 forks source link

Fix Router Push / Replace with URL Object #54

Closed laooola closed 4 years ago

laooola commented 4 years ago

I encountered some issues with Router.push and Router.replace in combination with url objects after updating to next@9.5.5. Turned out that the internal router api has been changed in 9.5.0 (see https://github.com/vercel/next.js/pull/14827). This PR accounts for these changes.

danielr18 commented 4 years ago

@laooola Thank you for the PR! I'll try to get it merged within the next 2 days.

laooola commented 4 years ago

@danielr18 I'd probably do a new major release as this change won't work for next < 9.5.0. Users on next >= 9.5.0 should use the new package version while users on next < 9.5.0 should stick with the previous one. This should also be documented somewhere e.g. in the readme?

danielr18 commented 4 years ago

@danielr18 I'd probably do a new major release as this change won't work for next < 9.5.0. Users on next >= 9.5.0 should use the new package version while users on next < 9.5.0 should stick with the previous one. This should also be documented somewhere e.g. in the readme?

Right, it'll be documented in the top section of the readme. Similar to how it was done for v3.0.0.