search

danielr18 / connected-next-router

A Redux binding for Next.js Router compatible with Next.js.
MIT License
109 stars 30 forks source link

Expose a LocationChangeAction type for TypeScript? #87

Closed JoshuaKGoldberg closed 2 years ago

JoshuaKGoldberg commented 2 years ago

Similar to #86. I'd be happy to send a PR for both/either of these issues.

TypeScript playground example

example.ts:1:27 - error TS2305: Module '"connected-next-router"' has no exported member 'LocationChangeAction'.

1 import { LOCATION_CHANGE, LocationChangeAction } from "connected-next-router";

The type is exported from connected-react-router: https://github.com/supasate/connected-react-router/blob/c6609e335c1b6bd3a2fce163d4d19beeb6d6a7ea/index.d.ts#L41

danielr18 commented 2 years ago

Hey @JoshuaKGoldberg, you can submit the PRs. I’ll review them and publish a new version fairly quick

danielr18 commented 2 years ago

Thanks @JoshuaKGoldberg. Version 4.1.1 is published

JoshuaKGoldberg commented 2 years ago

Amazing, thanks so much for the fast review and release!