Closed JamieSlome closed 6 months ago
[!WARNING]
Rate Limit Exceeded
@danielroe has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 32 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 1dabd86e63da93b3f8c8dea82995624add081831 and 94bacd94cf28b8716a5c1cb84207738da2f3d1c2.
The recent update introduces a visually engaging feature: conditional rendering of a confetti component on the web page when specific Lighthouse performance metrics are met. This enhancement not only celebrates achieving top scores but also extends to sharing achievements on social media by updating the og:image
with a festive confetti overlay.
File(s) | Change Summary |
---|---|
app.vue |
Added conditional rendering for a confetti component based on Lighthouse performance metrics. |
Objective | Addressed | Explanation |
---|---|---|
Add confetti to web page on CWV pass & 100/100 scores (#14) | β | |
Add confetti to og:image on social media share for 100/100 scores (#14) |
β | The provided summary does not mention changes related to the og:image or social media share. |
In the land of code, where metrics shine,
A rabbit hopped, with a design so fine.
π "Let's celebrate," it said with glee,
For scores so high, as good as can be.
With confetti in air, and joy all around,
Success in code, by leaps and bounds.
π° "Hop, hop, hooray!" the rabbit did cheer,
For a web much brighter, the goal is near.
ππ°π
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
New dependencies detected. Learn more about Socket for GitHub βοΈ
Package | New capabilities | Transitives | Size | Publisher |
---|---|---|---|---|
npm/@neoconfetti/vue@2.2.1 | None | 0 |
20.8 kB | puruvj |
The og:image
is proving hard to test. I am making changes directly to the OpenGraph folder yet don't see a change propagating?
I think we might need to do something like overlay a confetti SVG on the open graph image as we won't really be able to animate anything on it.
Makes sense. I'll have a muck around with the OpenGraph and find an SVG to layover the image. I'll also move the rendering logic to setup function with computed property as you did in the app.
@danielroe - I've used the static class from Stack Overflow's design library Stacks. It is under MIT π
I don't seem to be getting any visual feedback from the preview deployment. Is there some form of cache that might be taking time to refresh?
defaults: {
cacheMaxAgeSeconds: 60 * 60 * 24
},
The thing to do is open the Nuxt Devtools (little Nuxt logo on the page) and open up the OG image devtool... it should look like this. (You'll even get HMR when editing.)
Bear in mind there are some limitations on how OG images work; they are rendered by Satori so support a subset of Tailwind and style attributes.
Lovely, that helps big time! π
@danielroe - good to merge? π₯
Just want to see if the extra css in the lighthouse page can be server only
Thanks a lot for picking neoconfetti ππ
Thanks a lot for picking neoconfetti ππ
That starstruck feeling you get when the maintainer of a library reaches out β€οΈ
@PuruVJ - great job on @neoconfetti/vue
- clean, simple and works a charm π
@PuruVJ - can open a new issue on the repository, but it would be nice to have static confetti as well. Seems very little support for static confetti apart from Stacks by StackOverflow, and not a massive fan of copying and pasting code.
Sure, go ahead please! And Pull requests welcome too, won't be able to implement this for a while myself π
Closes #14
Summary by CodeRabbit