danielroe / page-speed.dev

https://page-speed.dev
MIT License
320 stars 13 forks source link

Add confetti to `og:image` and web page on CWV pass & 100/100 scores #18

Closed JamieSlome closed 6 months ago

JamieSlome commented 6 months ago

Closes #14

Summary by CodeRabbit

coderabbitai[bot] commented 6 months ago

[!WARNING]

Rate Limit Exceeded

@danielroe has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 32 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 1dabd86e63da93b3f8c8dea82995624add081831 and 94bacd94cf28b8716a5c1cb84207738da2f3d1c2.

Walkthrough

The recent update introduces a visually engaging feature: conditional rendering of a confetti component on the web page when specific Lighthouse performance metrics are met. This enhancement not only celebrates achieving top scores but also extends to sharing achievements on social media by updating the og:image with a festive confetti overlay.

Changes

File(s) Change Summary
app.vue Added conditional rendering for a confetti component based on Lighthouse performance metrics.

Assessment against linked issues

Objective Addressed Explanation
Add confetti to web page on CWV pass & 100/100 scores (#14) βœ…
Add confetti to og:image on social media share for 100/100 scores (#14) ❌ The provided summary does not mention changes related to the og:image or social media share.

Poem

In the land of code, where metrics shine,
A rabbit hopped, with a design so fine.
πŸŽ‰ "Let's celebrate," it said with glee,
For scores so high, as good as can be.
With confetti in air, and joy all around,
Success in code, by leaps and bounds.
🐰 "Hop, hop, hooray!" the rabbit did cheer,
For a web much brighter, the goal is near.

πŸŽ‰πŸ°πŸŽ‰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
socket-security[bot] commented 6 months ago

New dependencies detected. Learn more about Socket for GitHub β†—οΈŽ

Package New capabilities Transitives Size Publisher
npm/@neoconfetti/vue@2.2.1 None 0 20.8 kB puruvj

View full reportβ†—οΈŽ

JamieSlome commented 6 months ago

The og:image is proving hard to test. I am making changes directly to the OpenGraph folder yet don't see a change propagating?

danielroe commented 6 months ago

I think we might need to do something like overlay a confetti SVG on the open graph image as we won't really be able to animate anything on it.

JamieSlome commented 6 months ago

Makes sense. I'll have a muck around with the OpenGraph and find an SVG to layover the image. I'll also move the rendering logic to setup function with computed property as you did in the app.

JamieSlome commented 6 months ago

@danielroe - I've used the static class from Stack Overflow's design library Stacks. It is under MIT πŸ‘

JamieSlome commented 6 months ago

I don't seem to be getting any visual feedback from the preview deployment. Is there some form of cache that might be taking time to refresh?

defaults: {
    cacheMaxAgeSeconds: 60 * 60 * 24
},
Screenshot 2024-02-11 at 21 07 01
danielroe commented 6 months ago

The thing to do is open the Nuxt Devtools (little Nuxt logo on the page) and open up the OG image devtool... it should look like this. (You'll even get HMR when editing.)

CleanShot 2024-02-11 at 22 04 45@2x

Bear in mind there are some limitations on how OG images work; they are rendered by Satori so support a subset of Tailwind and style attributes.

JamieSlome commented 6 months ago

Lovely, that helps big time! πŸ’š

JamieSlome commented 6 months ago

@danielroe - good to merge? πŸ”₯

danielroe commented 6 months ago

Just want to see if the extra css in the lighthouse page can be server only

PuruVJ commented 6 months ago

Thanks a lot for picking neoconfetti πŸ™πŸ˜

JamieSlome commented 6 months ago

Thanks a lot for picking neoconfetti πŸ™πŸ˜

That starstruck feeling you get when the maintainer of a library reaches out ❀️

@PuruVJ - great job on @neoconfetti/vue - clean, simple and works a charm πŸ‘Œ

JamieSlome commented 6 months ago

@PuruVJ - can open a new issue on the repository, but it would be nice to have static confetti as well. Seems very little support for static confetti apart from Stacks by StackOverflow, and not a massive fan of copying and pasting code.

PuruVJ commented 6 months ago

Sure, go ahead please! And Pull requests welcome too, won't be able to implement this for a while myself πŸ™