search

danielroe / page-speed.dev

https://page-speed.dev
MIT License
320 stars 13 forks source link

HTML validity and accessibility issues #23

Open Youhan opened 6 months ago

Youhan commented 6 months ago

I can spot some issues regarding the validity of HTML (like putting div inside span, or form inside h1) and also there is room for adding aria-* for better accessibility.

Are you planning on a new design? If that's the case there will be huge changes on the markup I assume. That's why I am hesitating to fix the markup and accessibility cause that would cause HTML markup changes too.

What do you suggest? I can also contribute to implementing the new design and do the validity/accessibility stuff along the way.

danielroe commented 6 months ago

Thanks for spotting! Implemented some fixes for the HTML validation issues and added a module to ensure it doesn't happen again: https://github.com/danielroe/page-speed.dev/commit/28f1715669dcce509b56b243ec21d2f4b81b2935.

A new design might well be on the cards ...