coderabbitai[bot]
commented
8 months ago Walkthrough
The recent update simplifies the validation process within the application by removing a specific check for domain validity. This change suggests a shift towards a more lenient or different approach in handling domain verification, potentially relying on other mechanisms or assuming prior validation elsewhere.
Changes
| File | Change Summary |
|---|---|
app.vue |
Disabled domain validity check by commenting out error throw statement |
utils/validation.ts |
Added isValidDomain function for domain validation using regex pattern |
🐰✨
In the realm of code, where checks were once tight,
A rabbit hopped in, softening the oversight.
"Let's ease on the rules," it whispered with glee,
For a world more forgiving, as vast as the sea.
🌊🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
danielroe
Hi @danielroe,
This is a simple fix that removes throwing 500 (blank page) error when opening page-speed.dev with an invalid url (e.g. https://page-speed.dev/testtest).
Would be happy to update this to just prevent api call by adding var isValidDomain and showing v-else-if domain message. However, for now this seems to be inline with inputing an invalid url in input.
But probably the two should go together and implement the same regex used here for the input. This is just a temp fix to get page to load at least. LMK
Thanks!!
Summary by CodeRabbit