search

danielroich / PTI

Official Implementation for "Pivotal Tuning for Latent-based editing of Real Images" (ACM TOG 2022) https://arxiv.org/abs/2106.05744
MIT License
897 stars 112 forks source link

lpips seems broken - #29

Closed johndpope closed 3 years ago

johndpope commented 3 years ago

the latest version 0.1.4 seems to break things with missing layer

Traceback (most recent call last): File "scripts/notebook.py", line 63, in model_id = run_PTI(use_wandb=False, use_multi_id_training=use_multi_id_training) File "/home/jp/Documents/gitWorkspace/PTI/scripts/run_pti.py", line 40, in run_PTI coach = SingleIDCoach(dataloader, use_wandb) File "/home/jp/Documents/gitWorkspace/PTI/training/coaches/single_id_coach.py", line 13, in init super().init(data_loader, use_wandb) File "/home/jp/Documents/gitWorkspace/PTI/training/coaches/base_coach.py", line 36, in init self.lpips_loss = LPIPS(net=hyperparameters.lpips_type, lpips_layers=hyperparameters.pt_lpips_layers).to(global_config.device).eval() TypeError: init() got an unexpected keyword argument 'lpips_layers'

I'd submit a PR - but my branch has drifted considerably.

johndpope commented 3 years ago

wait a sec 0.1.2 has issues too.

(torch) ➜ PTI git:(main) ✗ python scripts/notebook.py Traceback (most recent call last): File "scripts/notebook.py", line 16, in from scripts.run_pti import run_PTI File "/home/jp/Documents/gitWorkspace/PTI/scripts/run_pti.py", line 9, in from training.coaches.multi_id_coach import MultiIDCoach File "/home/jp/Documents/gitWorkspace/PTI/training/coaches/multi_id_coach.py", line 7, in from training.coaches.base_coach import BaseCoach File "/home/jp/Documents/gitWorkspace/PTI/training/coaches/base_coach.py", line 9, in from lpips import LPIPS File "/home/jp/miniconda3/envs/torch/lib/python3.8/site-packages/lpips/init.py", line 7, in from skimage.measure import compare_ssim ImportError: cannot import name 'compare_ssim' from 'skimage.measure' (/home/jp/miniconda3/envs/torch/lib/python3.8/site-packages/skimage/measure/init.py)

johndpope commented 3 years ago

sorry merged a faulty branch.