Handle safe area bottom inset differently

danielsaidi / BottomSheet

BottomSheet lets you add custom bottom sheets to your SwiftUI apps.

MIT License

190 stars 12 forks source link

Handle safe area bottom inset differently #3

Closed digitalheir closed 3 years ago

digitalheir commented 3 years ago

Fix for #2.

Putting a ScrollView in a bottom sheet caused the system to put the bottom of the content in the safe area, obscuring some content in many cases.

I guess that maybe specifying the padding(.bottom, geo.safeAreaInsets.bottom) to the content view could be the user's responsibility, because they might intend the view to bleed into the safe area. Maybe it should be an optional 'bleed' setting?

danielsaidi commented 3 years ago

Thanks for looking into this! I will have a look as soon as possible.

danielsaidi commented 3 years ago

Looks great, thank you for fixing this!