search

danielsaidi / BottomSheet

BottomSheet lets you add custom bottom sheets to your SwiftUI apps.
MIT License
189 stars 12 forks source link

Scroll is very slow #8

Closed shywoody closed 2 years ago

shywoody commented 2 years ago

scroll very sllow when drag to full screen in simulator

danielsaidi commented 2 years ago

How does it behave on real devices? What kind of content do you have in the sheet?

jakeround commented 2 years ago

@shywoody I noticed simulator could drop a few frames every once and a while but on device it's behaves how you would expect.

shywoody commented 2 years ago

@shywoody I noticed simulator could drop a few frames every once and a while but on device it's behaves how you would expect.

oh~, thx. u r right. it's bad experience when run demo in simulator.

shywoody commented 2 years ago

How does it behave on real devices? What kind of content do you have in the sheet?

thx. 👍 , it runs smoothly in real devices. everything is perfer and i think that maybe we need a slide to dismiss or click blank space to dismiss function. i mean it was good enough.

danielsaidi commented 2 years ago

@shywoody Nice that it works well on real devices 👍

The intended use case is to mimic the system bottom sheet, but you can always use the context to control whether or not the bottom sheet is expanded.

danielsaidi commented 2 years ago

I'm keeping this around to see if I can improve the behavior in the simulator. There's no reason for this to lag just because you run it on a simulator.

shywoody commented 2 years ago

I'm keeping this around to see if I can improve the behavior in the simulator. There's no reason for this to lag just because you run it on a simulator.

that's very rigorous 👍

danielsaidi commented 2 years ago

Closing this since the library is now deprecated.