search

danielsaidi / DocumentKit

DocumentKit is a Swift SDK that adds more capabilities to DocumentGroup-based apps in SwiftUI.
MIT License
62 stars 3 forks source link

Not working with iOS 18 #6

Open cjhunt opened 2 months ago

cjhunt commented 2 months ago

The iOS DocumentGroup View/ViewController structure has changed a lot with iOS18. I've been trying and failing to modify your code to work with it. No joy so far. If you have any ideas please let me know. I'm happy to help with moving DocumentKit to iOS 18.

danielsaidi commented 2 months ago

Hi @cjhunt

Thank you for letting me know - I've been super busy with other projects and haven't had time to look into this, but I suspected that it would become a problem, given how the document group can now present a custom header.

The big question is if this library is needed anymore, with the additions of these things?

cjhunt commented 2 months ago

Thank you Daniel

Until now my primary use case for DocumentKit was adding custom actions to file/folder list items in the DocumentGroup's underlying UIDocumentBrowserViewController. With iOS 18 I've NOT found a way to achieve that with or without DocumentKit. Re your "big question" - it does seem that most of the other features of DocumentKit should be achievable directly in the iOS 18 DocumentGroup. In any case thank you for all the work you did creating a publishing DocumentKit!!

danielsaidi commented 2 months ago

Hi @cjhunt

I have just released a 0.5 that fixes the onboarding and splash screen by ignoring the strict requirement that the presenting screen should be a document browser.

However, since the underlying type has now moved from being a UIDocumentBrowserViewController to a new type, I'm afraid that much of the use (and needs) of this SDK goes out the window.

I will keep the SDK and this issue open for a while, but I have added information about that it will be removed when iOS 19 is released, unless I or you or someone else finds a reason for it to exist :)