danielsaidi / RichTextKit

RichTextKit is a Swift SDK that helps you use rich text in Swift and SwiftUI.

MIT License

950 stars 126 forks source link

RichTextAction subscription #129

Closed DominikBucher12 closed 9 months ago

DominikBucher12 commented 10 months ago

What this PR do:

Implements RichTextAction as main source of truth for Actions inside the richtextview. That means that setting isBold on RichTextContext no longer sets the style.
Properties on Context are now internal, meaning if you want to set some attributes from the outside, use userActionPublisher!
Fixes issue with sidebar focusing thus not setting typing attributes at given range.
How to test it
Run the test, try the app for yourself

TODO

[x] Implement integration tests
[x] Add Localizations for those user actions
[x] Clean up a bit.

DominikBucher12 commented 10 months ago

@danielsaidi Can you please take a look when you have some free time to ensure we are going correct direction?

This is breaking change, changing published properties to internal for them to reflect only and only be used with binding(for)...