search

danielscherzer / GLSL

VSIX Project that provides GLSL language integration.
257 stars 28 forks source link

Incorrect highlighting for push constants #107

Open JesperLykke opened 1 year ago

JesperLykke commented 1 year ago

Installed product versions

Description

I simply get a red squiggly line below my push constant - which compiles and works perfectly well.

image

helviett commented 1 year ago

Do you compile shader via external compiler? Do you pass -V argument to the external compiler?

JesperLykke commented 1 year ago

Hm.... I compile the shaders to Spir-V simply using the "glslc.exe" from the Vulkan SDK. I do not pass any special arguments. In either case, what should that have do with the syntax highlighting?

danielscherzer commented 11 months ago

The syntax highlighting ask the compiler set in the options for an error list and produces the squiggles.

RedGogh commented 4 weeks ago

I have this problem too, why do i need to pass -V argument to the external compiler? recommend remove this syntax highlighting check. because all developers understand what they are doing in any case.

danielscherzer commented 4 weeks ago

What do you mean by "remove this syntax highlighting check"?

To hopefully clarify: To create the red squiggles I need to know where the (compile) errors in the code are. If you set the external compiler in the options I use this compiler to generate the red squiggles. Depending on the external compiler you may need to use options, but this is specific to the external compiler you are using. If you do not set an external compiler I use the default compiler of your OpenGL driver. This driver does not understand Vulkan specific extensions to GLSL.

RedGogh commented 4 weeks ago

All right, i thought was it is a GLSL extension internal syntax highlighting check.