danielscherzer / GLSL

VSIX Project that provides GLSL language integration.
255 stars 27 forks source link

Default syntax highlight colors are bad for light theme #124

Open DPD85 opened 4 months ago

DPD85 commented 4 months ago

Installed product versions

Description

The default syntax highlight colors are bad with a light theme

Steps to recreate

  1. Set the light of blue theme of Visual Studio;
  2. open a GLSL shader file;
  3. look at the syntax highlight colors of the text.

Current behavior

The actual default syntax highlight colors make the text well readable only when a dark theme is used, so the background color is dark. When, instead, a light theme is used, so the background color is light (for example white), the text will be very hard to read. See the following picture as an example:

immagine

Expected behavior

The default syntax highlight colors should change accordingly with the used theme or the default colors should be good with light and dark themes (at least with the Visual Studio default themes).

danielscherzer commented 4 months ago

Thanks for your feedback! Yes, colors that are sensitive to the theme would be better. I hardcoded them in ClassificationTypes.t4 because I always use a dark theme. So the change would be a bit involved. I also do not know how to query the active Visual Studio theme colors. If you have any knowledge in this area, please feel free to imporve the code. Cheers, Daniel

DPD85 commented 4 months ago

Also I don't have any knowledge about this area.