search

danielscherzer / GLSL

VSIX Project that provides GLSL language integration.
257 stars 28 forks source link

Bad keybind interaction with other extensions #85

Closed ror3d closed 3 years ago

ror3d commented 3 years ago

Installed product versions

Description

When using the extension and an auto-complete popup appears, pressing Esc with using VsVim should close the popup AND put VsVim to normal-mode. What happens instead is that only the popup is closed.

Steps to recreate

  1. Open a shader file
  2. Start writing the name of an existing variable inside a function
  3. press Esc to close the popup and leave VsVim's insert-mode.

Current behavior

The popup is closed but insert-mode is still active, instead of being in normal-mode.

Expected behavior

The popup should be closed and VsVim should be in normal-mode.

In any other language server, when in insert-mode in VsVim, pressing Esc when an auto-complete popup is open closes the popup and leaves insert-mode.

I suspect for some reason the extension is capturing the key event and not letting it bubble up through other extensions.

danielscherzer commented 3 years ago

Thanks for your feedback! I created a new version of the extension 0.10.131, which hopefully resolves this issue.

ror3d commented 3 years ago

Seems to work as expected now, thank you very much!