danielschuster-muc / potter-db

A Harry Potter database for all your wizarding needs: Books, Characters, Movies, Spells, and Potions. Powered by https://github.com/danielschuster-muc/scrabby
https://potterdb.com
MIT License
98 stars 38 forks source link

Add Slovak translations #773

Closed romana-la closed 1 year ago

romana-la commented 1 year ago

Summary

Translation of the documentation into Slovak language.

Related Issues

Is part of #738

Checklist

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
potter-db ✅ Ready (Inspect) Visit Preview Oct 26, 2023 0:04am
potter-db-docs ✅ Ready (Inspect) Visit Preview Oct 26, 2023 0:04am
danielschuster-muc commented 1 year ago

Hi @romana-la, are there any updates from your side? Could you please resolve the requested changed, so I can merge you pr?

romana-la commented 1 year ago

Hi @danielschuster-muc, thanks for your feedback and sorry that it took me so long to get to it. I have implemented most of your suggestions. Re. having resources in both English and Slovak - I have dropped English from the statistics table but I would still keep it in the table of contents and titles. When somebody makes a request, they will have to specify the resource in the request URL in English. When they then look in the documentation for the explanation of attributes to interpret the response, they will be likely looking for the English word.

danielschuster-muc commented 1 year ago

Hi @danielschuster-muc, thanks for your feedback and sorry that it took me so long to get to it. I have implemented most of your suggestions. Re. having resources in both English and Slovak - I have dropped English from the statistics table but I would still keep it in the table of contents and titles. When somebody makes a request, they will have to specify the resource in the request URL in English. When they then look in the documentation for the explanation of attributes to interpret the response, they will be likely looking for the English word.

Yes, you definitely have a point, makes sense to have the resources names in English and Slovak. Thank you for your input.

kolja-lucht commented 1 year ago

Hey @danielschuster-muc could provide the German translation 🧙‍♀️

danielschuster-muc commented 1 year ago

Hey @danielschuster-muc could provide the German translation 🧙‍♀️

sure! maybe you can leave a short note in #738

kolja-lucht commented 1 year ago

Oops, I thought I had commented on that issue. Didn't realize I was in a PR 😅 Sorry about that @danielschuster-muc