danielschuster-muc / potter-db

A Harry Potter database for all your wizarding needs: Books, Characters, Movies, Spells, and Potions. Powered by https://github.com/danielschuster-muc/scrabby
https://potterdb.com
MIT License
98 stars 38 forks source link

[Ticket]: Create a ScrollToTop button #787

Closed danielschuster-muc closed 1 year ago

danielschuster-muc commented 1 year ago

Project

Website (potterdb.com)

Describe the ticket you want to create

For the new website it would be nice to have a scroll to top button such as we had on the old website.

It should be positioned in the bottom right of the page and only be visible when needed (e.g. unless you are a the top of the page). When clicked it should smoothly move the page to the top. For the icon make sure to use react-icons. Do not use any other packages.

Please be aware to make a branch from the new-website branch. Before start working on this ticket please leave a quick note below so I can assign you. If you have any questions please ping me.

Acceptance Criteria

Additional Details

No response

Screenshots

No response

Logs

No response

kristenking commented 1 year ago

Hello @danielschuster-muc ! Could I work on this issue please?

vyb2014962 commented 1 year ago

hi @danielschuster-muc ! can i take this?

danielschuster-muc commented 1 year ago

hi @danielschuster-muc ! can i take this?

sorry, @kristenking was first 😂 , but I will add some more tickets soon and if you have any ideas, feel free to open an feature request or discussion.

kristenking commented 1 year ago

Hey @danielschuster-muc , I just checked, and looks like the scroll-up button already exists on the newer version. Could you please confirm with me if there is anything else I can work on regarding this? screencapture-localhost-3001-2023-10-26-09_46_21

danielschuster-muc commented 1 year ago

Hey @danielschuster-muc , I just checked, and looks like the scroll-up button already exists on the newer version. Could you please confirm with me if there is anything else I can work on regarding this? screencapture-localhost-3001-2023-10-26-09_46_21

No, no, potterdb.com is actually the old website, checkout: https://beta.potterdb.com/

kristenking commented 1 year ago

Thank you for a quick response @danielschuster-muc ! I am new to this project and might need some guidance. I followed general guidelines to contribute to a front end and checked localhost: 3001. That gave me old version of the website. Where can I find the codebase for a new website?

Shantanu-Tiwari commented 1 year ago

Hey, I would like to work on this issue if its not being worked upon.

danielschuster-muc commented 1 year ago

Thank you for a quick response @danielschuster-muc ! I am new to this project and might need some guidance. I followed general guidelines to contribute to a front end and checked localhost: 3001. That gave me old version of the website. Where can I find the codebase for a new website?

You need to checkout to the new-website branch, e.g. with git checkout new-website.

danielschuster-muc commented 1 year ago

Hey, I would like to work on this issue if its not being worked upon.

Sorry, it’s already been working on.

kristenking commented 1 year ago

Thank you for a quick response @danielschuster-muc ! I am new to this project and might need some guidance. I followed general guidelines to contribute to a front end and checked localhost: 3001. That gave me old version of the website. Where can I find the codebase for a new website?

You need to checkout to the new-website branch, e.g. with git checkout new-website.

Cool, have it now, thanks so much @danielschuster-muc !