danielschuster-muc / potter-db

A Harry Potter database for all your wizarding needs: Books, Characters, Movies, Spells, and Potions. Powered by https://github.com/danielschuster-muc/scrabby
https://potterdb.com
MIT License
98 stars 38 forks source link

Add German translation for documentation #792

Closed kolja-lucht closed 1 year ago

kolja-lucht commented 1 year ago

Summary

Adding German translation for the documentation.

Related Issues

738

Checklist

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
potter-db-docs ✅ Ready (Inspect) Visit Preview Oct 30, 2023 9:07pm
1 Ignored Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **potter-db** | ⬜️ Ignored ([Inspect](https://vercel.com/danielschuster-muc/potter-db/GtEnEGfWLzUCwxHbkU47hteq7zjH)) | [Visit Preview](https://potter-db-git-fork-kolja-lucht-kolja-5b6c0f-danielschuster-muc.vercel.app) | Oct 30, 2023 9:07pm |
kolja-lucht commented 1 year ago

Hey @danielschuster-muc, my translations are ready for review 😊

danielschuster-muc commented 1 year ago

Hey @danielschuster-muc, my translations are ready for review 😊

I'll have a look at those later this evening. Takes a bit longer to review than #793 😂.

kolja-lucht commented 1 year ago

Fair enough 😆

kolja-lucht commented 1 year ago

Thanks for your review! I had a feeling you'd be a little stricter with German. All good 😀 Will push the changes during the day 👍

kolja-lucht commented 1 year ago

Could you also try to add an empty line after each #TITLE?

Do you mean only the top level titles or subheadings, too, like ## What's the Potter DB: API? @danielschuster-muc

kolja-lucht commented 1 year ago

@danielschuster-muc anything I can do to fix the vercel deployment?

danielschuster-muc commented 1 year ago

Could you also try to add an empty line after each #TITLE?

Do you mean only the top level titles or subheadings, too, like ## What's the Potter DB: API? @danielschuster-muc

Also subheadings

danielschuster-muc commented 1 year ago

Also regarding the failed build, here's an extract from the vercel log:

[nextra] Error compiling /vercel/path0/docs/pages/resources/spells.de.mdx.
--
15:37:05.109 | [nextra] The repository is shallow cloned, so the latest modified time will not be presented. Set the VERCEL_DEEP_CLONE=true environment variable to enable deep cloning.
15:37:22.964 | <w> [webpack.cache.PackFileCacheStrategy] Skipped not serializable cache item 'Compilation/modules\|/vercel/path0/docs/node_modules/next/dist/build/webpack/loaders/next-swc-loader.js??ruleSet[1].rules[12].use[0]!/vercel/path0/docs/node_modules/nextra/loader.js??ruleSet[1].rules[12].use[1]!/vercel/path0/docs/pages/resources/spells.de.mdx': No serializer registered for VFileMessage
15:37:22.964 | <w> while serializing webpack/lib/cache/PackFileCacheStrategy.PackContentItems -> webpack/lib/NormalModule -> webpack/lib/ModuleBuildError -> VFileMessage
15:37:23.686 | Failed to compile.
15:37:23.686 |  
15:37:23.686 | ./pages/resources/spells.de.mdx
15:37:23.686 | Could not parse expression with acorn: Unexpected token
15:37:23.686 |  
15:37:23.686 | Import trace for requested module:
15:37:23.686 | ./pages/resources/spells.de.mdx
15:37:23.686 |  
15:37:23.686 |  
15:37:23.686 | > Build failed because of webpack errors
15:37:23.801 | Error: Command "npm run build" exited with 1

looks like there is an issue with the spells resources page, please fix that.

danielschuster-muc commented 1 year ago

Could you please resolve finished conversations? That makes it easier for me to track your changes, thanks!

kolja-lucht commented 1 year ago

Could you please resolve finished conversations? That makes it easier for me to track your changes, thanks!

@danielschuster-muc Build is fixed, I pushed your recent change suggestions and resolved all conversations

kolja-lucht commented 1 year ago

Pushed the changes