danielsen / NetSPF

.NET SPF tools
MIT License
2 stars 3 forks source link

Static makes thing impossible to test #5

Open StephanMoeller opened 2 years ago

StephanMoeller commented 2 years ago

The loop issue mentioned by kristho can only be tested with real life dns settings proving the problem. This is due to the fact that everything is static. Instead you should remove all static methods will real classes with interfaces. This way there should be a IDnsResolver that will be mockable and the problem with internal loop will be testable without dependencies to the outside world.