danielsmith-eu / home-assistant-themeparks-integration

A Home Assistant integration that shows Theme Park waiting times using the ThemeParks.wiki API
Apache License 2.0
16 stars 8 forks source link

Easily identify entities related to parks #14

Closed BottlecapDave closed 3 months ago

BottlecapDave commented 4 months ago

Hello and thanks for the integration.

With the current implementation, you choose a resort to add. Unfortunately, this then includes merges all rides for all parks and are all grouped under a single device for the resort. This makes it very hard to work out which entities are for which parks without manually sorting them (e.g. Disneyland Resort includes rides for Disneyland and California adventure, but I might only be going to one of them)

Therefore it would be good if either

  1. When we set up the integration we select parks not resorts or
  2. When we select a resort, it creates a device per park instead of one for the resort and the entities names are clearly marked and assigned which park they are for instead of with the resort (e.g. sensor.guardians_of_the_galaxy_mission_breakout_disneyland_resort would be sensor.guardians_of_the_galaxy_mission_breakout_disney_california_adventure_park)
danielsmith-eu commented 3 months ago

Hi @BottlecapDave thanks for the issue.

I was about to come onto here and say that it's out of my hands and it's how the https://themeparks.wiki/ API does it, but I did check first, and the API does have both concepts, and this Integration should do something with the resort and parks.

Probably creating a new device per park makes sense, and then having an attribute on the device that specifies with resort will be a good MVP.

I think that device creation is a bit broken at the moment in the integration anyway, so this does need looking at properly, but having the dropdown select from parks instead of resorts work be the quickest fix.

I don't know anything about to code a migration strategy for existing users, so that would be helpful. There probably aren't that many users of the integration though, so i'd be happy to just swap to picking parks over resorts and call it a new major version.

@BottlecapDave do you want to have a bash at that and file a PR?

BottlecapDave commented 3 months ago

Thanks for getting back to me.

Sorry to be a pain, but I ended up creating my own integration using the API for what I wanted to achieve.

When I created this issue, I was hoping to build an integration that worked with your integration which monitored the standby/show times and notified me when the ride/attraction with the shortest time changed. However even with my suggested changes I quickly discovered it was going to be a lot more work than if I just got the data myself, which is what I've ended up doing.

I've yet to try my idea in the real world, so it might not work out :)

Feel free to close this issue.