search

danielspaniel / ember-data-change-tracker

extending ember data to track and rollback changes including objects and associations
MIT License
107 stars 44 forks source link

Autotracking regression in combination with ember-data-model-fragments & Ember 3.28 #109

Open pjcarly opened 2 years ago

pjcarly commented 2 years ago

I came across an autotracking regression in Ember 3.28. And after a long investigation it appears that the combination of this addon, together with ember-data-model-fragments causes the error.

An issue has been logged there as well: https://github.com/adopted-ember-addons/ember-data-model-fragments/issues/427

pjcarly commented 2 years ago

Reproduction app here: https://github.com/pjcarly/autotracking-regression-repro

edmondkong-storyful commented 2 months ago

Hi @pjcarly , did you ever find a workaround for this?

I'm running into the same error reported in the issue you linked above while attempting to upgrade my ember application from 3.24 to 3.28.

pjcarly commented 2 months ago

I am sorry but no, in the end we stopped using ember-data-change-tracker because of this.

edmondkong-storyful commented 2 months ago

May I ask, did you find a replacement library? Or did you have to do a refactor to mimic what ember-data-change-tracker does?

pjcarly commented 2 months ago

The last, we refactored our code to mimic this addon's behaviour, but also combined with upgrading Ember Data in order to benefit from changes in ED itself which also manage changes better.

edmondkong-storyful commented 2 months ago

I appreciate the responses, thank you @pjcarly