danielspaniel / ember-data-change-tracker

extending ember data to track and rollback changes including objects and associations
MIT License
106 stars 47 forks source link

Fix incorrect this._super on event methods #87

Closed davelindquist-egistix closed 4 years ago

davelindquist-egistix commented 4 years ago

As noted in #65 (Replace deprecated usage of Ember.Evented) the deprecation warnings continue to appear, due to the this._super calls inside the event definitions.

This pull request simply removes the this._super calls (thus removing the deprecation warnings).

As far as I can tell, the super calls are not needed anyway - walking through the code:

So it appears that the this._super in the event is not actually going to gain anything?

Can we bring in this pull request until the future-work is done to move away from the ready call/etc?

danielspaniel commented 4 years ago

Sure thing. Thanks for the PR and clean up in general. Let me know when you want new version put out.

davelindquist-egistix commented 4 years ago

Wow, that was fast work! :-)

Is it possible to get a new version? (Assuming you think my changes make sense.) We get a huge spew of deprecation warnings in our application (because there is a lot of data being loaded), so I'm currently pointing to my github fork instead of to a correct version.

Thanks!

danielspaniel commented 4 years ago

no problem -> V0.10.1 is now ready

davelindquist-egistix commented 4 years ago

Thanks!