search

danielstern / ngAudio

Angular Directive for Playing Sounds
http://danielstern.github.io/ngAudio/#/
MIT License
369 stars 137 forks source link

Added destroyed getter #178

Closed simonemazzoni closed 7 years ago

simonemazzoni commented 7 years ago

Hello, here is the PR related to #176

Added destroyed getter on NgAudioObject to check if an object has been destroyed or not.

Let me know if it looks ok.

Simone

danielstern commented 7 years ago

Looks good! Just one more thing, can you update the docs explaining the new feature? https://github.com/danielstern/ngAudio/blob/master/app/partial/ngAudioDocs.html

simonemazzoni commented 7 years ago

@danielstern, right now I don't have my laptop with me. I'll do it as soon as I can.

simonemazzoni commented 7 years ago

@danielstern sorry for the late. I updated the docs. Could you please merge it? Thanks.

danielstern commented 7 years ago

Thanks!

simonemazzoni commented 7 years ago

@danielstern Great! Could you please also update npm package with new version?